Fix bug with dummy output clients in local_det_chol rewrite
#393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jessegrabowski
changed the title
local_det_chol rewrite
ricardoV94
reviewed
Jul 20, 2023
ricardoV94
changed the title
local_det_chol rewritelocal_det_chol rewrite
ricardoV94
requested changes
Jul 20, 2023
ricardoV94
approved these changes
Jul 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for these changes
Closes #392, and also adds a test for
local_det_chol(it previously didn't have one)Implementation details
...
Checklist
Major / Breaking Changes
New features
Bugfixes
local_det_cholfails when functioninputsare included inoutputs#392Documentation
Maintenance